Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/12374#discussion_r72107064
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala ---
@@ -692,14 +692,20 @@ private[spark] object RandomForest extends Logging {
node.stats
}
- // For each (feature, split), calculate the gain, and select the best
(feature, split).
- val (bestSplit, bestSplitStats) =
- Range(0, binAggregates.metadata.numFeaturesPerNode).map {
featureIndexIdx =>
- val featureIndex = if (featuresForNode.nonEmpty) {
- featuresForNode.get.apply(featureIndexIdx)
+ val validFeatureSplits =
+ Range(0, binAggregates.metadata.numFeaturesPerNode).view.map {
featureIndexIdx =>
+ if (featuresForNode.nonEmpty) {
+ (featureIndexIdx, featuresForNode.get.apply(featureIndexIdx))
--- End diff --
I don't think so. The alternative is `featuresForNode.get(featureIndexIdx)`
which is misleading even though it does work. It looks like you are calling a
function `get` and passing `featureIndexIdx` as an argument. Explicit apply
seems clearer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
