GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/14350
[SPARK-16715][Tests]Fix a potential ExprId conflict for
SubexpressionEliminationSuite."Semantic equals and hash"
## What changes were proposed in this pull request?
SubexpressionEliminationSuite."Semantic equals and hash" assumes the
default AttributeReference's exprId wont' be "ExprId(1)". However, that depends
on when this test runs. It may happen to use "ExprId(1)".
This PR detects the conflict and makes sure we create a different ExprId
when the conflict happens.
## How was this patch tested?
Jenkins unit tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zsxwing/spark SPARK-16715
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/14350.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14350
----
commit 4c6dfbcc00c2675674fe8136b9daa2a7560de063
Author: Shixiong Zhu <shixi...@databricks.com>
Date: 2016-07-25T20:34:29Z
Fix a potential ExprId conflict for SubexpressionEliminationSuite."Semantic
equals and hash"
SubexpressionEliminationSuite."Semantic equals and hash" assumes the
default AttributeReference's exprId wont' be "ExprId(1)". However, that depends
on when this test runs. It may happen to use "ExprId(1)".
This PR detects the conflict and makes sure we create a different ExprId
when the conflict happens.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
