Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14340#discussion_r72176261
  
    --- Diff: 
external/kafka-0-10/src/main/scala/org/apache/spark/streaming/kafka010/KafkaUtils.scala
 ---
    @@ -177,3 +182,172 @@ object KafkaUtils extends Logging {
         }
       }
     }
    +
    +private[kafka010] class KafkaUtilsPythonHelper extends Logging {
    +  import KafkaUtilsPythonHelper._
    +
    +  def createDirectStream(
    +      jssc: JavaStreamingContext,
    +      locationStrategy: LocationStrategy,
    +      consumerStrategy: ConsumerStrategy[Array[Byte], Array[Byte]]
    +    ): JavaDStream[Array[Byte]] = {
    +    fixKafkaParams(consumerStrategy.executorKafkaParams)
    --- End diff --
    
    If we did a defensive copy on the map first, how do we set it back to 
`ConsumerStrategy`, I'm not pretty sure how to achieve this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to