Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14323#discussion_r72179607
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -138,6 +138,80 @@ object JdbcUtils extends Logging {
throw new IllegalArgumentException(s"Can't get JDBC type for
${dt.simpleString}"))
}
+ // A `JDBCValueGetter` is responsible for converting, getting a value
from `Row`
+ // and then setting into a field for `PreparedStatement`. The last
argument
+ // `Int` means the index for the value to be set in the SQL statement
and also used
+ // for the value to retrieve from `Row`.
+ private type JDBCValueGetter = (PreparedStatement, Row, Int) => Unit
--- End diff --
hmm, I think `setter` is a more proper name here, and we should use
`getter` for the read path.
`JDBCValueGetter`, sounds like we get the value from JDBC.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
