Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/14258
Thanks @junyangq - this is looking pretty good. It would be good to add a
test for this (some discussion below).
@mengxr The R package version is still set as 2.0.0 in `DESCRIPTION` - so
we should be able to test this right now. In fact it might be good to be able
to force the Spark version to use in `install_spark` instead of using
`packageVersion` just for testing.
The other thing I worry is if downloading 300 MB and un-tar might take too
long to run on Jenkins. Also if we do add a test on jenkins, we should clean up
the download, cache dirs etc.
@felixcheung I think the Scala version is dictated by the default builds we
do for release. So for example `Starting version 2.0, Spark is built with Scala
2.11 by default` -- Users who want to use Scala 2.10 need to build their own
tgz anyways and can point `install_spark` to the relevant files.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
