Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/14308#discussion_r72834486
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaNGramExample.java ---
@@ -55,16 +55,12 @@ public static void main(String[] args) {
Dataset<Row> wordDataFrame = spark.createDataFrame(data, schema);
- NGram ngramTransformer = new
NGram().setInputCol("words").setOutputCol("ngrams");
+ NGram ngramTransformer = new
NGram().setN(2).setInputCol("words").setOutputCol("bigrams");
--- End diff --
I really only think that the param `N` should be set explicitly. Looking
back, changing the column name was not necessary, let me change that back.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
