Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14398#discussion_r72845861
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -875,11 +878,20 @@ object DateTimeUtils {
val hh = seconds / 3600
val mm = seconds / 60 % 60
val ss = seconds % 60
- val nano = millisOfDay % 1000 * 1000000
+ val millis = millisOfDay % 1000
+ // Choose calendar based on java.util.Date getCalendarSystem
+ val calendar = if (year >= 1582) {
+ CalendarSystem.getGregorianCalendar()
--- End diff --
For this to happen millisLocal would have to be negative... which is at
least well defined, but, would certainly need to be defined relative to January
1 1970 in the Gregorian calendar?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
