Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/14346#discussion_r72880469
--- Diff: R/pkg/R/mllib.R ---
@@ -119,7 +121,7 @@ NULL
#' @note spark.glm since 2.0.0
#' @seealso \link{glm}, \link{read.ml}
setMethod("spark.glm", signature(data = "SparkDataFrame", formula =
"formula"),
- function(data, formula, family = gaussian, tol = 1e-6, maxIter =
25) {
+ function(data, formula, family = gaussian, weightCol = NULL, tol
= 1e-6, maxIter = 25) {
--- End diff --
you might not want to add a parameter in the middle of the list. if someone
has existing code calling this function in parameter order it might misalign
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
