Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/14427#discussion_r72898570
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategySuite.scala
---
@@ -407,6 +407,39 @@ class FileSourceStrategySuite extends QueryTest with
SharedSQLContext with Predi
}
}
+ test("[SPARK-16818] partition pruned file scans implement sameResult
correctly") {
+ withTempPath { path =>
+ val tempDir = path.getCanonicalPath
+ spark.range(100)
+ .selectExpr("id", "id as b")
+ .write
+ .partitionBy("id")
+ .parquet(tempDir)
+ val df = spark.read.parquet(tempDir)
+ def getPlan(df: DataFrame): SparkPlan = {
+ df.queryExecution.executedPlan
+ }
+ assert(getPlan(df.where("id = 2")).sameResult(getPlan(df.where("id =
2"))))
+ assert(!getPlan(df.where("id = 2")).sameResult(getPlan(df.where("id
= 3"))))
+ }
+ }
+
+ test("[SPARK-16818] exchange reuse respects differences in partition
pruning") {
+ spark.conf.set("spark.sql.exchange.reuse", true)
--- End diff --
Oh, I assumed the test already did so since I've seen this pattern
elsewhere. If it affects more than just the suite, I can submit a follow-up
fix.
On Sat, Jul 30, 2016, 10:59 PM Reynold Xin <notificati...@github.com> wrote:
> In
>
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategySuite.scala
> <https://github.com/apache/spark/pull/14427#discussion_r72898521>:
>
> > + spark.range(100)
> > + .selectExpr("id", "id as b")
> > + .write
> > + .partitionBy("id")
> > + .parquet(tempDir)
> > + val df = spark.read.parquet(tempDir)
> > + def getPlan(df: DataFrame): SparkPlan = {
> > + df.queryExecution.executedPlan
> > + }
> > + assert(getPlan(df.where("id =
2")).sameResult(getPlan(df.where("id = 2"))))
> > + assert(!getPlan(df.where("id =
2")).sameResult(getPlan(df.where("id = 3"))))
> > + }
> > + }
> > +
> > + test("[SPARK-16818] exchange reuse respects differences in partition
pruning") {
> > + spark.conf.set("spark.sql.exchange.reuse", true)
>
> ah actually just realized we could've improved with by using "withSQLConf"
> -- it makes sure the configs get reset after the test case finishes
running.
>
> â
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/spark/pull/14427/files/ef60367331fb3097040cfb0849bdc314c8d399ea#r72898521>,
> or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/AAA6Sun3Ai6lEtCs9dcjaxlAtO3Y_a2Qks5qbDnQgaJpZM4JY91Z>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
