GitHub user tmagrino opened a pull request:
https://github.com/apache/spark/pull/14441
[SPARK-16837] [SQL] TimeWindow incorrectly drops slideDuration in
constructors
## What changes were proposed in this pull request?
Fix of incorrect arguments (dropping slideDuration and using
windowDuration) in constructors for TimeWindow.
The JIRA this addresses is here:
https://issues.apache.org/jira/browse/SPARK-16837
## How was this patch tested?
Added a test to TimeWindowSuite to check that the results of TimeWindow
object apply and TimeWindow class constructor are equivalent.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tmagrino/spark windowing-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/14441.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14441
----
commit 9835eb337398deedfdb9ef455554a1fdef45eee1
Author: Tom Magrino <tmagr...@fb.com>
Date: 2016-08-01T17:44:03Z
Quick fix of incorrect argument in TimeWindow constructors.
commit e1450f8e972ae50c05bed338d527ff3158c114a9
Author: Tom Magrino <tmagr...@fb.com>
Date: 2016-08-01T18:29:33Z
Added a test to check that TimeWindow object apply is equivalent to the
TimeWindow class constructors.
commit 0e0136a248b483893dcc545c8d7b7a6e91a8c027
Author: Tom Magrino <tmagr...@fb.com>
Date: 2016-08-01T18:33:37Z
Cleaning up unnecessary changes.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
