Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14439#discussion_r73064350
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -157,6 +145,26 @@ object TypeCoercion {
})
}
+ /**
+ * Similar to [[findWiderCommonType]], but can't promote to string.
+ */
+ private def findWiderTypeWithoutStringPromotion(types: Seq[DataType]):
Option[DataType] = {
--- End diff --
It is weird that its name is `findWiderTypeWithoutStringPromotion` because
`findTightestCommonTypeOfTwo` is used inside. Also, let's add more docs to this
method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
