Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/13893#discussion_r73126756 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala --- @@ -64,10 +64,17 @@ object PhysicalOperation extends PredicateHelper { val substitutedFields = fields.map(substitute(aliases)).asInstanceOf[Seq[NamedExpression]] (Some(substitutedFields), filters, other, collectAliases(substitutedFields)) - case Filter(condition, child) if condition.deterministic => + case Filter(condition, child) => val (fields, filters, other, aliases) = collectProjectsAndFilters(child) - val substitutedCondition = substitute(aliases)(condition) - (fields, filters ++ splitConjunctivePredicates(substitutedCondition), other, aliases) + + // Deterministic parts of filter condition placed before non-deterministic predicates could + // be pushed down safely. + val (pushDown, rest) = --- End diff -- @cloud-fan Thanks for your comment! But I did searched the codebase and found the returned `filters` only used for predicates pushdown or partition pruning, in both case it should be safe for us to drop the `rest` condition. Thank you!
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org