Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14419#discussion_r73320252
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetCompatibilityTest.scala
---
@@ -119,8 +119,18 @@ private[sql] object ParquetCompatibilityTest {
metadata: Map[String, String],
recordWriters: (RecordConsumer => Unit)*): Unit = {
val messageType = MessageTypeParser.parseMessageType(schema)
- val writeSupport = new DirectWriteSupport(messageType, metadata)
- val parquetWriter = new ParquetWriter[RecordConsumer => Unit](new
Path(path), writeSupport)
+ val testWriteSupport = new DirectWriteSupport(messageType, metadata)
+ class ParquetWriterBuilder() extends
+ ParquetWriter.Builder[RecordConsumer => Unit,
ParquetWriterBuilder](new Path(path)) {
+ @Override def getWriteSupport(conf:
org.apache.hadoop.conf.Configuration) = {
--- End diff --
Import `Configuration`? and maybe just write the trivial body of both
methods inline without braces on one line. Just personal taste really, to keep
this anonymous class compact
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
