Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14482#discussion_r73387263 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -349,6 +384,27 @@ trait CheckAnalysis extends PredicateHelper { |${s.catalogTable.identifier} """.stripMargin) + case c @ CreateTable(tableDesc, mode, query) if c.resolved => + // Since we are saving table metadata to metastore, we should make sure the table name + // and database name don't break some common restrictions, e.g. special chars except + // underscore are not allowed. + val pattern = Pattern.compile("[\\w_]+") --- End diff -- Move this somewhere we can reuse it.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org