Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14065#discussion_r73419090
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/security/AMCredentialRenewer.scala
---
@@ -27,39 +27,42 @@ import org.apache.hadoop.security.UserGroupInformation
import org.apache.spark.SparkConf
import org.apache.spark.deploy.SparkHadoopUtil
+import org.apache.spark.deploy.yarn.YarnSparkHadoopUtil
import org.apache.spark.deploy.yarn.config._
import org.apache.spark.internal.Logging
import org.apache.spark.internal.config._
import org.apache.spark.util.ThreadUtils
-/*
+/**
* The following methods are primarily meant to make sure long-running
apps like Spark
- * Streaming apps can run without interruption while writing to secure
HDFS. The
- * scheduleLoginFromKeytab method is called on the driver when the
- * CoarseGrainedScheduledBackend starts up. This method wakes up a thread
that logs into the KDC
- * once 75% of the renewal interval of the original delegation tokens used
for the container
- * has elapsed. It then creates new delegation tokens and writes them to
HDFS in a
+ * Streaming apps can run without interruption while accessing security
services. The
+ * scheduleLoginFromKeytab method is called on the AM to get the new
credentials.
+ * This method wakes up a thread that logs into the KDC
+ * once 75% of the renewal interval of the original credentials used for
the container
+ * has elapsed. It then obtain new credentials and writes them to HDFS in a
--- End diff --
nit: obtains
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
