Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14488#discussion_r73457856
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -749,25 +749,44 @@ case class ParseUrl(children: Seq[Expression])
Pattern.compile(REGEXPREFIX + key.toString + REGEXSUBFIX)
}
- private def getUrl(url: UTF8String): URL = {
+ private def getUrl(url: UTF8String): URI = {
try {
- new URL(url.toString)
+ new URI(url.toString)
} catch {
- case e: MalformedURLException => null
+ case e: URISyntaxException => null
--- End diff --
Don't change this unless you need to make another change anyway, but this
can be `case _: ...` I know it wasn't like that before
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
