Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14502#discussion_r73714157
--- Diff: core/src/main/scala/org/apache/spark/rdd/JdbcRDD.scala ---
@@ -79,12 +79,18 @@ class JdbcRDD[T: ClassTag](
val conn = getConnection()
val stmt = conn.prepareStatement(sql, ResultSet.TYPE_FORWARD_ONLY,
ResultSet.CONCUR_READ_ONLY)
- // setFetchSize(Integer.MIN_VALUE) is a mysql driver specific way to
force streaming results,
- // rather than pulling entire resultset into memory.
- // see
http://dev.mysql.com/doc/refman/5.0/en/connector-j-reference-implementation-notes.html
- if (conn.getMetaData.getURL.matches("jdbc:mysql:.*")) {
+ val url = conn.getMetaData.getURL
+ if (url.matches("jdbc:mysql:.*")) {
+ // setFetchSize(Integer.MIN_VALUE) is a mysql driver specific way to
force streaming results,
+ // rather than pulling entire resultset into memory.
+ // see
http://dev.mysql.com/doc/refman/5.0/en/connector-j-reference-implementation-notes.html
+
stmt.setFetchSize(Integer.MIN_VALUE)
logInfo("statement fetch size set to: " + stmt.getFetchSize + " to
force MySQL streaming ")
+ } else if (url.matches("jdbc:postgresql:*")) {
--- End diff --
OK got it. We'll leave that, but perhaps `setFetchSize(100)` for everything
else. @princejwesley
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
