Github user markhamstra commented on the pull request:
https://github.com/apache/spark/pull/1992#issuecomment-52413400
Something seems to be amiss in this PR: Several of your changes are neither
in `master` already nor are they showing up in `Files changed`. Mismerged?
And some of your changes don't really go all the way toward cleaning up the
logic. For example,
```scala
(aclsEnabled() && (user != null) && (!viewAcls.contains(user))) == false
```
would be better as
```scala
!aclsEnabled || user == null || viewAcls.contains(user)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
