Github user vanzin commented on the issue:

    https://github.com/apache/spark/pull/12753
  
    Hmmm... wouldn't this be a one line change (for standalone and mesos) if 
instead you modified `CommandUtils.buildLocalCommand` to apply variable 
substitution to `command.javaOpts` instead of just to `command.arguments`?
    
    That would replace `{{EXECUTOR_ID}}` in any of the arguments, since that 
variable is already in the list of things to replace (see 
`ExecutorRunner.substituteVariables`.)
    
    You'd still need some extra code for YARN since it doesn't use that path. 
But it would be a smaller change that re-uses existing functionality.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to