Github user eyalfa commented on a diff in the pull request: https://github.com/apache/spark/pull/14444#discussion_r73788331 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -1101,7 +1101,7 @@ class AstBuilder extends SqlBaseBaseVisitor[AnyRef] with Logging { * Create a [[CreateStruct]] expression. */ override def visitRowConstructor(ctx: RowConstructorContext): Expression = withOrigin(ctx) { - CreateStruct(ctx.expression.asScala.map(expression)) + CreateStruct(ctx.expression.asScala.map(expression)).toCreateNamedStruct --- End diff -- @cloud-fan this process tow-constructor expression of the form `(1,"a") as col1(a,b)`. I could basically leave this as a `CreateStruct` but than I'd had to do something like transformDown in `visitInlineTable` which is basically the reason for this mess.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org