Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14511#discussion_r73868759
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -463,9 +455,20 @@ private[spark] class MesosClusterScheduler(
.mkString(",")
options ++= Seq("--py-files", formattedFiles)
}
- desc.conf.getAll
+
+ // --conf
+ val replicatedOptionsBlacklist = Set(
+ "spark.jars", // Avoids duplicate classes in classpath
+ "spark.submit.deployMode", // this would be set to `cluster`, but we
need client
+ "spark.master" // this contains the address of the dispatcher, not
master
+ )
+ val defaultConf =
conf.getAllWithPrefix("spark.mesos.dispatcher.driverProperty.").toMap
+ val driverConf = desc.conf.getAll
.filter { case (key, _) => !replicatedOptionsBlacklist.contains(key)
}
- .foreach { case (key, value) => options ++= Seq("--conf",
s"$key=${shellEscape(value)}") }
+ .toMap
+ (defaultConf ++ driverConf).foreach { case (key, value) =>
--- End diff --
what if I have the same property assigned both at driverConf and
defaultConf should not be the case that the former takes precedence?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
