Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/14534#discussion_r73908742
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/server/SparkSQLOperationManager.scala
---
@@ -39,8 +39,10 @@ private[thriftserver] class SparkSQLOperationManager()
val handleToOperation = ReflectionUtils
.getSuperField[JMap[OperationHandle, Operation]](this,
"handleToOperation")
- val sessionToActivePool = Map[SessionHandle, String]()
- val sessionToContexts = Map[SessionHandle, SQLContext]()
+ val sessionToActivePool = new mutable.HashMap[SessionHandle, String]()
--- End diff --
Correct; SynchronizedMap has been deprecated since Scala 2.11.0 with this
comment in the API docs: "Synchronization via traits is deprecated as it is
inherently unreliable. Consider java.util.concurrent.ConcurrentHashMap as an
alternative."
The title of this PR must be updated to match what is actually being done
after the switch to use ConcurrentHashMap since we don't want the misleading
"Add SynchronizedMap trait" to persist in the commit history.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
