Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14207#discussion_r73965912 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -95,17 +95,39 @@ case class CreateDataSourceTableCommand( } // Create the relation to validate the arguments before writing the metadata to the metastore. - DataSource( - sparkSession = sparkSession, - userSpecifiedSchema = userSpecifiedSchema, - className = provider, - bucketSpec = None, - options = optionsWithPath).resolveRelation(checkPathExist = false) + val dataSource: BaseRelation = + DataSource( + sparkSession = sparkSession, + userSpecifiedSchema = userSpecifiedSchema, + className = provider, + bucketSpec = None, + options = optionsWithPath).resolveRelation(checkPathExist = false) + + val partitionColumns = if (userSpecifiedSchema.nonEmpty) { + userSpecifiedPartitionColumns + } else { + val res = dataSource match { + case r: HadoopFsRelation => r.partitionSchema.fieldNames + case _ => Array.empty[String] + } + if (userSpecifiedPartitionColumns.length > 0) { --- End diff -- Here, I just keep the existing behavior. To be honest, I think we should throw an exception whenever it makes sense. It sounds like the job log is not being read by most users. Will submit a follow-up PR to make it a change. Thanks!
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org