Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14546#discussion_r73998693
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1252,7 +1252,9 @@ class Analyzer(
case ae: AnalysisException => filter
}
- case sort @ Sort(sortOrder, global, aggregate: Aggregate) if
aggregate.resolved =>
+ case sort @ Sort(sortOrder, global, aggregate: Aggregate)
+ if aggregate.resolved && sortOrder.forall(x =>
IntegerIndex.unapply(x.child).isEmpty) =>
--- End diff --
We have a conf `conf.orderByOrdinal` to control whether the integer values
are parsed as position. Thus, the current fix ignores this conf. Could you fix
it? Also added a test case to ensure both options are covered. That is, `true`
and `false`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
