Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14554#discussion_r74000577
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala
 ---
    @@ -41,22 +42,23 @@ object PartitionDirectory {
      * Holds a directory in a partitioned collection of files as well as as 
the partition values
      * in the form of a Row.  Before scanning, the files at `path` need to be 
enumerated.
      */
    -private[sql] case class PartitionDirectory(values: InternalRow, path: Path)
    +case class PartitionDirectory(values: InternalRow, path: Path)
     
    -private[sql] case class PartitionSpec(
    +case class PartitionSpec(
         partitionColumns: StructType,
         partitions: Seq[PartitionDirectory])
     
    -private[sql] object PartitionSpec {
    +object PartitionSpec {
       val emptySpec = PartitionSpec(StructType(Seq.empty[StructField]), 
Seq.empty[PartitionDirectory])
     }
     
    -private[sql] object PartitioningUtils {
    +object PartitioningUtils {
       // This duplicates default value of Hive 
`ConfVars.DEFAULTPARTITIONNAME`, since sql/core doesn't
       // depend on Hive.
    -  private[sql] val DEFAULT_PARTITION_NAME = "__HIVE_DEFAULT_PARTITION__"
    +  val DEFAULT_PARTITION_NAME = "__HIVE_DEFAULT_PARTITION__"
     
    -  private[sql] case class PartitionValues(columnNames: Seq[String], 
literals: Seq[Literal]) {
    +  private[datasources] case class PartitionValues(columnNames: 
Seq[String], literals: Seq[Literal])
    --- End diff --
    
    here too


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to