Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14551#discussion_r74005614
  
    --- Diff: core/src/test/scala/org/apache/spark/util/UtilsSuite.scala ---
    @@ -874,4 +874,38 @@ class UtilsSuite extends SparkFunSuite with 
ResetSystemProperties with Logging {
           }
         }
       }
    +
    +  test("chi square test of randomizeInPlace") {
    +    // Parameters
    +    val arraySize = 10
    +    val numTrials = 1000
    +    val threshold = 0.05
    +    val seed = 1L
    +
    +    // results[i][j]: how many times Utils.randomize moves an element from 
position j to position i
    +    val results: Array[Array[Long]] = Array.ofDim(arraySize, arraySize)
    --- End diff --
    
    Some minor style things -- just omit the type here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to