Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14558#discussion_r74017287
  
    --- Diff: R/pkg/R/generics.R ---
    @@ -1022,6 +1059,7 @@ setGeneric("month", function(x) { 
standardGeneric("month") })
     #' @export
     setGeneric("months_between", function(y, x) { 
standardGeneric("months_between") })
     
    +#' @param x a SparkDataFrame or a Column object.
     #' @rdname nrow
    --- End diff --
    
    here for "n" column function, it shouldn't be under rdname nrow, which is 
for count for DataFrame - I'd change this to a new rdname, `count` and put 
"count" and "n" under that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to