GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/14564
[SPARK-16886][EXAMPLES][DOCS] Fix some examples to be consistent and
woring, and indentation in documentation
## What changes were proposed in this pull request?
Originally this PR was based on #14491 but I realised that fixing examples
are more sensible rather than comments.
This PR fixes three things below:
- Fix two wrong examples in `structured-streaming-programming-guide.md`.
Loading via `read.load(..)` without `as` will be `Dataset<Row>` not
`Dataset<String>` in Java.
- Fix indentation across `structured-streaming-programming-guide.md`.
Python has 4 spaces and Scala and Java have double spaces. These are
inconsistent across the examples.
- Fix `StructuredNetworkWordCountWindowed` and
`StructuredNetworkWordCount` in Java and Scala to initially load `DataFrame`
and `Dataset<Row>` to be consistent with the comments and some examples in
`structured-streaming-programming-guide.md` and to match Scala and Java to
Python one (Python one loads it as `DataFrame` initially).
## How was this patch tested?
N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HyukjinKwon/spark SPARK-16886
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/14564.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14564
----
commit 8751e08b18b8f8a4467cf15f88076c0f93294fc2
Author: Ganesh Chand <ganeshchand@ganeshs-macbook-pro-2.local>
Date: 2016-08-04T02:29:40Z
[SPARK-16886] [SQL] structured streaming network word count examples code
comments
Replaced Dataframe with Dataset in code comments
commit 3615806f8f5f08c22a10aa712e9d0ad8e9a8b1c6
Author: hyukjinkwon <gurwls...@gmail.com>
Date: 2016-08-09T10:36:00Z
Fix some examples to be consistent and indentation in documentation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
