Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/14537#discussion_r74092457
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -287,14 +287,14 @@ private[hive] class
HiveMetastoreCatalog(sparkSession: SparkSession) extends Log
new Path(metastoreRelation.catalogTable.storage.locationUri.get),
partitionSpec)
+ val schema =
--- End diff --
Thanks for refactoring this.
I think it makes more sense if
defaultSource.inferSchema(sparkSession, options, fileCatalog.allFiles())
is called `inferredSchema` and the value of the `if
(fileType.equals("parquet"))` expression is called `schema`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
