Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14539#discussion_r74100376
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
 ---
    @@ -769,3 +769,41 @@ case object OneRowRelation extends LeafNode {
        */
       override lazy val statistics: Statistics = Statistics(sizeInBytes = 1)
     }
    +
    +/**
    + * An inline table that holds a number of foldable expressions, which can 
be materialized into
    + * rows. This is semantically the same as a Union of one row relations.
    + */
    +case class InlineTable(rows: Seq[Seq[NamedExpression]]) extends LeafNode {
    --- End diff --
    
    Yeah, I had these checks. The thing is that none of the LogicalPlans have 
such logic, it has all been centralized in CheckAnalysis. So I added it there.
    
    It might not be a bad plan to move this functionality into the separate 
plans on the longer run.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to