Github user junyangq commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14258#discussion_r74125149
  
    --- Diff: R/pkg/R/sparkR.R ---
    @@ -365,6 +365,23 @@ sparkR.session <- function(
         }
         overrideEnvs(sparkConfigMap, paramMap)
       }
    +  # do not download if it is run in the sparkR shell
    +  if (!grepl(".*shell\\.R$", Sys.getenv("R_PROFILE_USER"), perl = TRUE)) {
    +    if (!nzchar(master) || is_master_local(master)) {
    --- End diff --
    
    Ah, since the install function is restricted to local for now, perhaps we 
only have to do the check for local master? If so, then I think it would be 
better to flip the order of `if` statements...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to