Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/14568#discussion_r74138850
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/MonotonicallyIncreasingID.scala
---
@@ -40,13 +40,14 @@ import org.apache.spark.sql.types.{DataType, LongType}
represent the record number within each partition. The assumption is
that the data frame has
less than 1 billion partitions, and each partition has less than 8
billion records.""",
extended = "> SELECT _FUNC_();\n 0")
-case class MonotonicallyIncreasingID() extends LeafExpression with
Nondeterministic {
+case class MonotonicallyIncreasingID(offset: Long = 0) extends
LeafExpression
--- End diff --
```
case class HyperLogLogPlusPlus(
child: Expression,
relativeSD: Double = 0.05,
mutableAggBufferOffset: Int = 0,
inputAggBufferOffset: Int = 0)
```
The change seems to be in line with HyperLogLogPlusPlus ctor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
