Github user ajbozarth commented on a diff in the pull request:
https://github.com/apache/spark/pull/12990#discussion_r74151754
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -137,6 +138,17 @@ class JobProgressListener(conf: SparkConf) extends
SparkListener with Logging {
)
}
+ /** If Tasks is too large, remove and garbage collect old tasks */
+ private def trimTasksIfNecessary(taskData: HashMap[Long, TaskUIData]) =
synchronized {
+ if (taskData.size > retainedTasks) {
+ val toRemove = math.max(retainedTasks / 10, 1)
+ val oldIds =
taskData.map(_._2.taskInfo.taskId).toList.sorted.take(toRemove)
--- End diff --
Also @tgravescs before I make the new pr, what's your opinion on this bit
of code? Should I leave this as is or change it to match how jobs and stages
are trimmed? I don't see a probe;em with this code, but I don't know why he
decided to implement it differently than the precedent.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
