Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14155#discussion_r74166431
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -689,4 +689,38 @@ class HiveDDLSuite
))
}
}
+
+ test("datasource table property keys are not allowed") {
+ import org.apache.spark.sql.hive.HiveExternalCatalog.DATASOURCE_PREFIX
+
+ withTable("tbl") {
+ sql("CREATE TABLE tbl(a INT) STORED AS parquet")
+
+ val e = intercept[AnalysisException] {
+ sql(s"ALTER TABLE tbl SET TBLPROPERTIES ('${DATASOURCE_PREFIX}foo'
= 'loser')")
+ }
+ assert(e.getMessage.contains(DATASOURCE_PREFIX + "foo"))
--- End diff --
The `HiveExternalCatalog`. My concern is that, this limitation is because
of the tricks for hive metastore, so it should only exist in
`HiveExternalCatalog`, the `InMemoryCatatalog` and our new metastore in the
future should not have this limitation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
