Github user junyangq commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14558#discussion_r74170002
  
    --- Diff: R/pkg/R/mllib.R ---
    @@ -563,11 +574,12 @@ read.ml <- function(path) {
     #' \code{predict} to make predictions on new data, and 
\code{write.ml}/\code{read.ml} to
     #' save/load fitted models.
     #'
    -#' @param data A SparkDataFrame for training
    -#' @param formula A symbolic description of the model to be fitted. 
Currently only a few formula
    +#' @param data a SparkDataFrame for training.
    +#' @param formula a symbolic description of the model to be fitted. 
Currently only a few formula
     #'                operators are supported, including '~', ':', '+', and 
'-'.
     #'                Note that operator '.' is not supported currently
    -#' @return \code{spark.survreg} returns a fitted AFT survival regression 
model
    +#' @param ... additional argument(s) passed to the method.
    --- End diff --
    
    I noticed those and thought about leaving space for potential arguments in 
the future... but I guess a cleaner solution would be as you said, to remove 
these arguments and add back if needed in the future.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to