Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14555#discussion_r74208355
--- Diff:
mllib-local/src/main/scala/org/apache/spark/ml/linalg/Vectors.scala ---
@@ -560,11 +554,26 @@ class SparseVector @Since("2.0.0") (
@Since("2.0.0") val indices: Array[Int],
@Since("2.0.0") val values: Array[Double]) extends Vector {
- require(indices.length == values.length, "Sparse vectors require that
the dimension of the" +
- s" indices match the dimension of the values. You provided
${indices.length} indices and " +
- s" ${values.length} values.")
- require(indices.length <= size, s"You provided ${indices.length} indices
and values, " +
- s"which exceeds the specified vector size ${size}.")
+ // validate the data
+ {
+ require(size >= 0, "The size of the requested sparse vector must be
greater than 0.")
+ require(indices.length == values.length, "Sparse vectors require that
the dimension of the" +
+ s" indices match the dimension of the values. You provided
${indices.length} indices and " +
+ s" ${values.length} values.")
+ require(indices.length <= size, s"You provided ${indices.length}
indices and values, " +
+ s"which exceeds the specified vector size ${size}.")
+
+ var prev = -1
+ if (indices.nonEmpty) {
+ require(indices(0) >= 0, s"Found negative index: ${indices(0)}.")
+ }
+ indices.foreach { i =>
+ require(prev < i, s"Found duplicate index: $i.")
+ prev = i
+ }
+ require(prev < size, s"You may not write an element to index $prev
because the declared " +
--- End diff --
Maybe more direct as `s"Index $prev out of bounds for vector of size
$size"`? the way it starts it seems like the problem is something being
read-only.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
