Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14534#discussion_r74211500
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/server/SparkSQLOperationManager.scala
---
@@ -39,15 +38,17 @@ private[thriftserver] class SparkSQLOperationManager()
val handleToOperation = ReflectionUtils
.getSuperField[JMap[OperationHandle, Operation]](this,
"handleToOperation")
- val sessionToActivePool = Map[SessionHandle, String]()
- val sessionToContexts = Map[SessionHandle, SQLContext]()
+ val sessionToActivePool = new ConcurrentHashMap[SessionHandle, String]()
+ val sessionToContexts = new ConcurrentHashMap[SessionHandle,
SQLContext]()
override def newExecuteStatementOperation(
parentSession: HiveSession,
statement: String,
confOverlay: JMap[String, String],
async: Boolean): ExecuteStatementOperation = synchronized {
- val sqlContext = sessionToContexts(parentSession.getSessionHandle)
+ val sqlContext = sessionToContexts.get(parentSession.getSessionHandle)
+ require(sqlContext != null, s"Session handle:
${parentSession.getSessionHandle} has not been" +
+ s" initialed or had already closed.")
--- End diff --
One last tiny nit: initaled -> initialized
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
