Github user mgummelt commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r74298546 --- Diff: core/src/test/scala/org/apache/spark/scheduler/cluster/mesos/Utils.scala --- @@ -19,15 +19,19 @@ package org.apache.spark.scheduler.cluster.mesos import java.util.Collections +import scala.collection.JavaConverters._ + import org.apache.mesos.Protos._ -import org.apache.mesos.Protos.Value.Scalar +import org.apache.mesos.Protos.Value.{Range => MesosRange, Ranges, Scalar} import org.apache.mesos.SchedulerDriver import org.mockito.{ArgumentCaptor, Matchers} import org.mockito.Mockito._ -import scala.collection.JavaConverters._ object Utils { - def createOffer(offerId: String, slaveId: String, mem: Int, cpu: Int): Offer = { + def createOffer( --- End diff -- params should follow this style https://github.com/databricks/scala-style-guide#spacing-and-indentation
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org