Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/14079#discussion_r74339234
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -52,13 +51,23 @@ import org.apache.spark.util.{AccumulatorV2,
ThreadUtils, Utils}
* acquire a lock on us, so we need to make sure that we don't try to lock
the backend while
* we are holding a lock on ourselves.
*/
-private[spark] class TaskSchedulerImpl(
+private[spark] class TaskSchedulerImpl private[scheduler](
--- End diff --
I think I was thinking just make it completely private (but leave it as a
constructor -- the reason you said seems important).
Sent from my iPhone
> On Aug 10, 2016, at 2:39 PM, Imran Rashid <notificati...@github.com>
wrote:
>
> In core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala:
>
> > @@ -52,13 +51,23 @@ import org.apache.spark.util.{AccumulatorV2,
ThreadUtils, Utils}
> > * acquire a lock on us, so we need to make sure that we don't try to
lock the backend while
> > * we are holding a lock on ourselves.
> > */
> > -private[spark] class TaskSchedulerImpl(
> > +private[spark] class TaskSchedulerImpl private[scheduler](
> just to make sure I understand -- do you want to eliminate having it be a
parameter for the constructor to TaskSchedulerImpl completely, so that it is
always created from the conf? I think that would prevent proper testing, since
I couldn't eg. pass in a mock.
>
> Or keep the constructor, but just make blacklistTracker completely
private, (not private[scheduler])? That should be straightforward, all the
tests which directly create a TaskSetManager would just use None for the
blacklist.
>
> â
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or mute the thread.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
