Github user junyangq commented on a diff in the pull request:
https://github.com/apache/spark/pull/14558#discussion_r74350887
--- Diff: R/pkg/R/generics.R ---
@@ -1046,8 +1084,8 @@ setGeneric("ntile", function(x) {
standardGeneric("ntile") })
#' @export
setGeneric("n_distinct", function(x, ...) { standardGeneric("n_distinct")
})
-#' @rdname percent_rank
-#' @export
+# @rdname percent_rank
--- End diff --
Yeah that works if we also set the argument list of the generic counterpart
to `...`. Then we still have to document the `...` part. We could tell the user
things like "this should be left empty". I'm not sure if that would cause some
confusion?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
