Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/14555
  
    OK, one last over-arching comment. I know the arg validation logic was 
split over two methods, and I think it was on purpose, so that calls to the 
`SparseVector` constructor didn't pay the full overhead of checking all the 
values. (CC @jkbradley did we talk about this a long time ago?) I think that 
may be something desirable to leave in place, even if it won't matter to 
callers of `Vectors.sparse`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to