Github user hvanhovell commented on the issue:

    https://github.com/apache/spark/pull/14599
  
    The `L`, `S` & `Y` suffixes come from Hive.
    
    The fix that is proposed by @petermaxlee has a potential problem when we 
try parse something like `a-1`. This will be tokenized into an `IDENTIFIER` and 
a `INTEGER_VALUE` instead of `IDENTIFIER` `MINUS` and a `INTEGER_VALUE`; the 
first one will result in a `ParserException`. This is because the lexer applies 
its rules in a greedy fashion.
    
    This PR does not have this problem because it uses a parser rule, and we 
can set presence there by ordering the rules (the sequence in which they are 
defined). Here binary minus takes precedence over unary minus. We could add 
this rule for the other dataTypes, but that is IMO merely a matter of 
aesthetics.
    
     


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to