Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14568#discussion_r74463138
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/MonotonicallyIncreasingID.scala
 ---
    @@ -81,3 +93,12 @@ case class MonotonicallyIncreasingID() extends 
LeafExpression with Nondeterminis
     
       override def sql: String = s"$prettyName()"
     }
    +
    +object MonotonicallyIncreasingID {
    +  private def parseExpression(expr: Expression): Long = expr match {
    +    case IntegerLiteral(i) => i.toLong
    +    case NonNullLiteral(l, LongType) => l.toString.toLong
    --- End diff --
    
    You can stack pattern matches. So `l: Long` will compile.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to