Github user heathermiller commented on the pull request:
https://github.com/apache/spark/pull/1929#issuecomment-52532231
So, this is isn't my area of expertise (I'm not sure who at Typesafe/EFPL
is currently responsible for the development/maintenance of the REPL, thus I
don't know who could comment on future plans/roadmap)
However,
1. I think the reliance of this patch on `invalidateClassPathEntries`
(removed in scala/scala#3884) is inconsequential because I get from
@gkossakowskiâs comment
(https://github.com/scala/scala/pull/3884#issuecomment-49277957) that this
functionality can easily (and will most likely) be provided by the 2.11.xâs
new classpath handling code. So, the approach taken in this PR is _probably_
still valid into 2.11. Though, obligatory to note that of course, we don't know
yet what it'll look like, or precisely when itâll hit, but since SI-6502 is
"major" and it has an owner, I would bet on it being included in 2.11.x.
2. There were some questions above about reflection â I second your Java
reflection-based approach for two reasons. (1) As many know, Scala reflection
is not thread-safe in 2.10.x, but perhaps more importantly (2) itâs an
experimental API that is still fluctuating, and has fluctuated quite a bit so
far between 2.10.x and 2.11.x. That said, itâs just a safer, stabler bet to
rely on Java reflection if you can for now.
Since Iâm not the foremost expert on this stuff, Iâm also going to ping
@gkossakowski (our best bet haha) â hopefully he can confirm/deny/clarify
these insights?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
