Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14615#discussion_r74547777 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -2494,16 +2494,18 @@ class Dataset[T] private[sql]( * @since 2.0.0 */ def toJSON: Dataset[String] = { - val rowSchema = this.schema - val rdd: RDD[String] = queryExecution.toRdd.mapPartitions { iter => + import sparkSession.implicits.newStringEncoder --- End diff -- where is the encoder used? I'd prefer to make this more explicit now it is farther apart from the import.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org