Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14585#discussion_r74555775
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonFileFormat.scala
 ---
    @@ -54,7 +54,7 @@ class JsonFileFormat extends TextBasedFileFormat with 
DataSourceRegister {
               
.getOrElse(sparkSession.sessionState.conf.columnNameOfCorruptRecord)
           val jsonFiles = files.filterNot { status =>
             val name = status.getPath.getName
    -        name.startsWith("_") || name.startsWith(".")
    +        (name.startsWith("_") && !name.contains("=")) || 
name.startsWith(".")
    --- End diff --
    
    Hm.. @dongjoon-hyun Do you mind if I ask a question?
    
    If my understanding is correct, the `name` will be `part-..` file whether 
the parent directory contains `_` or not. So, it would be unnecessary extra 
checking. It is happening in `ParquetFileFormat` as well.
    
    Do you mind if I open a follow-up to clean up those?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to