Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/14279
  
    @srowen I think it is okay as a separate PR.
    
    I believe adding the things I said for a follow-up will mess up the change 
and make this hard to be reviewed. Nevertheless, I don't mind adding it here 
together if any of you think they should be included here.
    
    Just FYI, the listed ones (for a follow-up above) are,
      1. an existing issue.
      2. enabling the related tests (which was disabled by 1).
      3. cleaning up codes (which I avoided here to make the review easier).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to