Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14155#discussion_r74665317
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -207,15 +310,52 @@ private[spark] class HiveExternalCatalog(client:
HiveClient, hadoopConf: Configu
assert(tableDefinition.identifier.database.isDefined)
val db = tableDefinition.identifier.database.get
requireTableExists(db, tableDefinition.identifier.table)
+ verifyTableProperties(tableDefinition)
--- End diff --
alterTable is my main concern. It is possible that `tableDefinition` is in
the standard form. But, the actual metadata stored in the metastore is using
properties to store schema. Then, the alterTable may just fail or significantly
change the metadata in metastore.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
