Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14229#discussion_r74676368
  
    --- Diff: R/pkg/R/mllib.R ---
    @@ -605,6 +701,69 @@ setMethod("spark.survreg", signature(data = 
"SparkDataFrame", formula = "formula
                 return(new("AFTSurvivalRegressionModel", jobj = jobj))
               })
     
    +#' Latent Dirichlet Allocation
    +#'
    +#' \code{spark.lda} fits a Latent Dirichlet Allocation model on a 
SparkDataFrame. Users can call
    +#' \code{summary} to get a summary of the fitted LDA model, 
\code{spark.posterior} to compute
    +#' posterior probabilities on new data, \code{spark.perplexity} to compute 
log perplexity on new
    +#' data and \code{write.ml}/\code{read.ml} to save/load fitted models.
    +#'
    +#' @param data A SparkDataFrame for training
    +#' @param features Features column name, default "features". Either Vector 
format column or String
    --- End diff --
    
    "Vector format column or String format column are accepted."
    not quite sure what we are saying here - are we trying to say one or 
multiple columns are ok? if so, perhaps say "character vector with a length one 
or more"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to