Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14627 Yes, it is not. I am sorry for the confusion. It seems your fix is perfectly fine and correct but it is just a clean-up to get rid of duplicated logics. BTW, I am also okay with removing the test added here if you think the existing tested added in your PR is enough!
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org